samredai commented on code in PR #4632:
URL: https://github.com/apache/iceberg/pull/4632#discussion_r859156110
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -140,21 +170,73 @@ public static MetadataUpdate fromJson(JsonNode jsonNode) {
throw new UnsupportedOperationException("Not implemented: AssignUUID");
case UPGRADE_FORMAT_VERSION:
return readAsUpgradeFormatVersion(jsonNode);
+ case ADD_SCHEMA:
+ return readAsAddSchema(jsonNode);
+ case SET_CURRENT_SCHEMA:
+ return readAsSetCurrentSchema(jsonNode);
+ case SET_DEFAULT_PARTITION_SPEC:
+ return readAsSetDefaultPartitionSpec(jsonNode);
+ case ADD_PARTITION_SPEC:
+ case ADD_SORT_ORDER:
+ case SET_DEFAULT_SORT_ORDER:
+ case ADD_SNAPSHOT:
+ case REMOVE_SNAPSHOTS:
Review Comment:
Since the class is `RemoveSnapshot`, should we make this singular, meaning
`REMOVE_SNAPSHOT`. This is a nit but all of the other actions seem to match the
class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
