snazy commented on code in PR #4594:
URL: https://github.com/apache/iceberg/pull/4594#discussion_r858865394
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -755,6 +755,10 @@ public static Builder buildFrom(TableMetadata base) {
return new Builder(base);
}
+ public static Builder buildFrom(TableMetadata base, boolean noPreviousFile) {
Review Comment:
That's a "smart thing" in the builder. If it's present, then it add it as a
history item. That behavior is okay, when `buildFrom()` is only used when it is
used within a "modify `TableMetadata` operation". But the Nessie catalog only
uses it to modify the `TableMetadata` as it is - so it's not a change, which
requires a new history-item.
Without the `noPreviousFile==true`, a couple of catalog tests fail, because
those assert on the number of history items.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
