kbendick commented on PR #4553: URL: https://github.com/apache/iceberg/pull/4553#issuecomment-1110109959
> ```diff > + // https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/#table-exec-sink-upsert-materialize > + // UPDATED - Needed to make testChangeLogOnDataKey work. > + // TODO - Add tests with all configuraiton values as follow up - and possibly remove our own injected shuffle > + // as Flink can now do it. > + getTableEnv().getConfig().set("table.exec.sink.upsert-materialize", "NONE"); > ``` > > This is interesting. Let's just replace those comments by the following ? > > ``` > + // Set the table.exec.sink.upsert-materialize=NONE, so that downstream operators will receive the records with the same orders as the source operator. > ``` I updated it (and added a note about bypassing Flink's shuffle). We should open an issue to consider allowing for Flink to handle the shuffling where necessary. Or set the necessary configuration by default for users - though I'm generally not in favor of changing the defaults and would prefer to let Flink handle the shuffle if at all possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
