kbendick opened a new pull request, #4635:
URL: https://github.com/apache/iceberg/pull/4635

   When upgrading our Flink code for the upcoming Flink 1.15 release in 
https://github.com/apache/iceberg/pull/4553, it was discovered that there is a 
failing test: 
https://github.com/apache/iceberg/pull/4553#issuecomment-1107688576
   
   Looking closer, the expected and actual results are the same, just in a 
different order.
   
   Because we are not testing the ordering of records returned from the source 
here, using list comparison doesn't make sense and we can just use set 
comparison (with an initial size check) for any query that returns more than 1 
record.
   
   I have updated all queries in this test to use set comparison semantics as 
list comparison is inherently flakey.
   
   I will port this over to Flink 1.15 in 
https://github.com/apache/iceberg/pull/4553 as that's where tests are failing.
   
   cc @openinx @yittg 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to