kbendick commented on PR #4635: URL: https://github.com/apache/iceberg/pull/4635#issuecomment-1111423337
Added a utility function `assertSameElements` into `FlinkTestBase`. In the interest of keeping the diff minimal, I didn't remove existing assertions on the size of the result (although that is checked by `assertSameElements`. I also didn't update any of the results with only one element. If we want to do that, we can use `Collections.singleton` to reuse the comparison. Let me know if removing the (redundant) size checks is a good idea. I think so because in the case of a failure, we'll see the incorrect records instead of just the incorrect size but I opted to be conservative and change less code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
