szehon-ho commented on code in PR #4629:
URL: https://github.com/apache/iceberg/pull/4629#discussion_r860118298
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestExpireSnapshotsAction.java:
##########
@@ -967,7 +990,77 @@ public void
testExpireOlderThanWithRollbackAndMergedManifests() {
FILE_B.path()), // added, but rolled back
deletedFiles);
- checkExpirationResults(1, 1, 1, result);
+ checkExpirationResults(1, 0, 0, 1, 1, result);
+ }
+
+ @Test
+ public void testExpireOlderThanWithDeleteFile() {
+ table.updateProperties()
+ .set(TableProperties.FORMAT_VERSION, "2")
+ .set(TableProperties.MANIFEST_MERGE_ENABLED, "false")
Review Comment:
Yea as this test checks the exact list of files removed for ExpireSnapshots,
I thought it's simpler to get the exact list if we don't have to deal with
manifests auto-merging after some time, as then, I just need to get manifests
from the latest snapshot.
Though in this case, I tried and it seems not necessary as the auto-merge
does not kick in (default is set high). I was thinking to keep it in case the
algorithm changes and manifests start merging, failing this test, but I am open
if it's better to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
