rajarshisarkar commented on code in PR #4629:
URL: https://github.com/apache/iceberg/pull/4629#discussion_r860856799
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestExpireSnapshotsAction.java:
##########
@@ -967,7 +990,77 @@ public void
testExpireOlderThanWithRollbackAndMergedManifests() {
FILE_B.path()), // added, but rolled back
deletedFiles);
- checkExpirationResults(1, 1, 1, result);
+ checkExpirationResults(1, 0, 0, 1, 1, result);
+ }
+
+ @Test
+ public void testExpireOlderThanWithDeleteFile() {
+ table.updateProperties()
+ .set(TableProperties.FORMAT_VERSION, "2")
+ .set(TableProperties.MANIFEST_MERGE_ENABLED, "false")
Review Comment:
I see, makes sense to me to keep the manifest merge as false here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
