kbendick commented on code in PR #4632:
URL: https://github.com/apache/iceberg/pull/4632#discussion_r860144484


##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -56,6 +56,19 @@ private MetadataUpdateParser() {
   // UpgradeFormatVersion
   private static final String FORMAT_VERSION = "format-version";
 
+  // AddSchema
+  private static final String SCHEMA = "schema";
+  private static final String LAST_COLUMN_ID = "last-column-id";
+
+  // SetCurrentSchema
+  private static final String SCHEMA_ID = "schema-id";
+
+  // AddPartitionSpec
+  private static final String SPEC = "spec";

Review Comment:
   Originally I had it in this PR, but I realized I had some concerns around 
`fieldId`, so I took it out to allow that conversation to be had in a more 
isolated place.
   
   Seems I forgot to remove its fields. My bad!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to