kbendick commented on code in PR #4635:
URL: https://github.com/apache/iceberg/pull/4635#discussion_r861412270
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkTableSource.java:
##########
@@ -119,7 +119,7 @@ public void testLimitPushDown() {
Row.of(2, "b", 20.0),
Row.of(3, null, 30.0)
);
- Assert.assertEquals("Should produce the expected records", expectedList,
resultExceed);
+ assertSameElements(expectedList, resultExceed);
Review Comment:
So you mean add a description argument like `assertSameElements(String
errorMessage, List<Row> exepected, List<Row> actual)`?
I'm happy to add that as well as keep the original signature. I can't think
of a place in the current file that it would be useful as they're all the same
scenarios, but I'm happy to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
