rdblue commented on code in PR #4580: URL: https://github.com/apache/iceberg/pull/4580#discussion_r862117852
########## api/src/main/java/org/apache/iceberg/IncrementalAppendScan.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +package org.apache.iceberg; + +/** + * API for configuring an incremental table scan for appends only snapshots + */ +public interface IncrementalAppendScan extends Scan<IncrementalAppendScan> { + + /** + * Refine the incremental scan with the start snapshot inclusive. + * <p> + * If the start snapshot (inclusive or exclusive) is not provided, + * the oldest ancestor of the {@link IncrementalAppendScan#toSnapshot(long)} + * will be included as the start snapshot. Review Comment: I don't think the proposed behavior makes sense for this interface. Otherwise, there is no way to incrementally scan from the start of the table. If I want to start from the beginning of history, I need to specify starting snapshot `null`. But there's no way to do that without leaving out the "from" snapshot. If that's how to configure scanning from the start of history, then this can't scan from the oldest known snapshot by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
