samredai opened a new pull request, #4679: URL: https://github.com/apache/iceberg/pull/4679
This adds an `UnboundReference` class that has a `bind` method which returns a `BoundReference` class. Merging this relies on PR #4678 which adds the `Schema.accessor_for_field` method. For complete functionality, a subsequent PR needs to be opened that implements the `struct` method in the `BuildPositionAccessors` visitor (added in the other PR) that builds a map of field ID to schema position accessor (the same PR should probably include tests for `UnboundReference` and `BuildPositionAccessors`. To summarize: - [ ] Review and merge PR #4678 - [ ] Review and merge this PR - [ ] Follow-up with an update to PR #4678 that adds the logic for building the field ID -> Accessor map - [ ] Follow-up with tests for `BuildPositionAccessors` and `UnboundReference` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
