emkornfield commented on code in PR #4679:
URL: https://github.com/apache/iceberg/pull/4679#discussion_r864458255
##########
python/src/iceberg/expressions/base.py:
##########
@@ -328,3 +329,49 @@ def eval(self, struct: StructProtocol) -> Any:
Any: The value at the referenced field's position in `struct`
"""
return self._accessor.get(struct)
+
+
+class UnboundReference:
+ """A reference not yet bound to a field in a schema
+
+ Args:
+ name (str): The name of the field
Review Comment:
it might pay to provide more details on name here for nested fields, or at
least point to other documentation on how they are expected to be referred to.
This isn't directly related to this PR, but i could find in the
specification what is considered a valid field name other than the fact that
they can contain periods "." at least for imports. This is quite possibly user
error though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
