rdblue commented on code in PR #4685:
URL: https://github.com/apache/iceberg/pull/4685#discussion_r864981327
##########
python/src/iceberg/schema.py:
##########
@@ -290,6 +292,8 @@ def _(obj: StructType, visitor: SchemaVisitor[T]) -> T:
visitor.before_field(field)
try:
result = visit(field.type, visitor)
+ except Exception:
+ logger.exception("Unable to visit the field in the schema")
Review Comment:
Should this also log which field wasn't handled? Something like `f"Unable to
visit field: {field}"`?
##########
python/src/iceberg/schema.py:
##########
@@ -290,6 +292,8 @@ def _(obj: StructType, visitor: SchemaVisitor[T]) -> T:
visitor.before_field(field)
try:
result = visit(field.type, visitor)
+ except Exception:
+ logger.exception("Unable to visit the field in the schema")
Review Comment:
Should this also log which field wasn't handled? Something like `f"Unable to
visit schema field: {field}"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
