samredai commented on code in PR #4685:
URL: https://github.com/apache/iceberg/pull/4685#discussion_r865358439
##########
python/src/iceberg/expressions/base.py:
##########
@@ -278,6 +278,9 @@ def __str__(self):
def __repr__(self):
return f"Accessor(position={self._position})"
+ def __eq__(self, other):
+ return other and self._position == other.position
Review Comment:
We don't manipulate the `self._position` property so this is just a nitpick,
but should we use `self.position` here instead just so it goes through that
path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
