stevenzwu commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r867261600
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -169,32 +176,23 @@ public CloseableIterable<T>
findEqualityDeleteRows(CloseableIterable<T> records)
.reduce(Predicate::or)
.orElse(t -> false);
- Filter<T> deletedRowsFilter = new Filter<T>() {
- @Override
- protected boolean shouldKeep(T item) {
- return deletedRows.test(item);
- }
- };
- return deletedRowsFilter.filter(records);
+ return Deletes.filter(records, deletedRows);
}
private CloseableIterable<T> applyEqDeletes(CloseableIterable<T> records) {
- // Predicate to test whether a row should be visible to user after
applying equality deletions.
- Predicate<T> remainingRows = applyEqDeletes().stream()
- .map(Predicate::negate)
- .reduce(Predicate::and)
- .orElse(t -> true);
-
- Filter<T> remainingRowsFilter = new Filter<T>() {
- @Override
- protected boolean shouldKeep(T item) {
- return remainingRows.test(item);
- }
- };
+ Predicate<T> isEqDeleted = applyEqDeletes().stream()
+ .reduce(Predicate::or)
+ .orElse(t -> false);
- return remainingRowsFilter.filter(records);
+ if (hasColumnIsDeleted) {
+ return Deletes.markDeleted(records, isEqDeleted, this::markRowDeleted);
+ } else {
+ return Deletes.filter(records, isEqDeleted.negate());
+ }
}
+ protected abstract void markRowDeleted(T item);
Review Comment:
provide a default impl here s for throwing `UnsupportedOperationException`
so that we don't need to change too many extended classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
