stevenzwu commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r867264550
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -63,13 +65,23 @@ public static <T> CloseableIterable<T>
filter(CloseableIterable<T> rows, Functio
return equalityFilter.filter(rows);
}
- public static <T> CloseableIterable<T> filter(CloseableIterable<T> rows,
Function<T, Long> rowToPosition,
- PositionDeleteIndex deleteSet)
{
- if (deleteSet.isEmpty()) {
- return rows;
- }
+ public static <T> CloseableIterable<T> markDeleted(CloseableIterable<T>
rows, Predicate<T> isDeleted,
+ Consumer<T> markDeleted) {
+ return CloseableIterable.transform(rows, row -> {
+ if (isDeleted.test(row)) {
+ markDeleted.accept(row);
+ }
+ return row;
+ });
+ }
- PositionSetDeleteFilter<T> filter = new
PositionSetDeleteFilter<>(rowToPosition, deleteSet);
+ public static <T> CloseableIterable<T> filter(CloseableIterable<T> rows,
Predicate<T> shouldKeep) {
Review Comment:
I like the new filter method API. only concern is for compatibility. this is
a public static method from a public class. Probably very few users call this
API directly. if we want to be safe, we can keep the old API and mark it as
deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
