Fokko commented on code in PR #4728:
URL: https://github.com/apache/iceberg/pull/4728#discussion_r867672939
##########
python/src/iceberg/transforms.py:
##########
@@ -120,9 +120,6 @@ def hash(self, value: S) -> int:
raise NotImplementedError()
def apply(self, value: S) -> Optional[int]:
- if value is None:
Review Comment:
Since we have `S`, it can never be `None`, otherwise, the signature should
be `Optional[S]`. If we want, we can still check if it `None`, `""` or `[]`
using:
```python
if not value:
```
I've removed it for now, because according to the current definition it is
unreachable code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
