rdblue commented on code in PR #4728:
URL: https://github.com/apache/iceberg/pull/4728#discussion_r868746492
##########
python/src/iceberg/transforms.py:
##########
@@ -83,10 +83,8 @@ def preserves_order(self) -> bool:
def satisfies_order_of(self, other) -> bool:
return self == other
- def to_human_string(self, value) -> str:
- if value is None:
- return "null"
- return str(value)
+ def to_human_string(self, value: Optional[S]) -> str:
+ return str(value) if value is not None else "null"
Review Comment:
Is this change necessary for this PR? We generally try to avoid code churn
that isn't making functional changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
