flyrain commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r868245630
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:
##########
@@ -72,46 +84,74 @@ public final ColumnarBatch read(ColumnarBatch reuse, int
numRowsToRead) {
}
private class ColumnBatchLoader {
- private int[] rowIdMapping; // the rowId mapping to skip deleted rows for
all column vectors inside a batch
- private int numRows;
private ColumnarBatch columnarBatch;
+ private final int batchSize;
+ private int[] rowIdMapping; // the rowId mapping to skip deleted rows for
all column vectors inside a batch
+ private boolean[] isDeleted; // the array to indicate if a row is deleted
or not
- ColumnBatchLoader(int numRowsToRead) {
- initRowIdMapping(numRowsToRead);
- loadDataToColumnBatch(numRowsToRead);
+ ColumnBatchLoader(int batchSize) {
Review Comment:
OK, I can change it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
