flyrain commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r868434937
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##########
@@ -153,10 +153,15 @@ public ArrowColumnVector getChild(int ordinal) {
return accessor.childColumn(ordinal);
}
- static ColumnVector forHolder(VectorHolder holder, int numRows) {
- return holder.isDummy() ?
- new ConstantColumnVector(Types.IntegerType.get(), numRows,
((ConstantVectorHolder) holder).getConstant()) :
- new IcebergArrowColumnVector(holder);
+ static ColumnVector forHolder(VectorHolder holder, int numRows, boolean[]
isDeleted) {
+ if (holder.isDummy()) {
+ if (holder instanceof VectorHolder.IsDeletedVectorHolder) {
+ return new DeletedMetaColumnVector(Types.BooleanType.get(), isDeleted);
+ }
+ return new ConstantColumnVector(Types.IntegerType.get(), numRows,
((ConstantVectorHolder) holder).getConstant());
Review Comment:
Checked and refactored this part of code by adding a column vector builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
