samredai commented on code in PR #4685: URL: https://github.com/apache/iceberg/pull/4685#discussion_r868676643
########## python/tests/conftest.py: ########## @@ -19,7 +19,7 @@ import pytest -from iceberg import schema +from iceberg.schema import Schema Review Comment: I think it matters more for the files containing actual tests (for example `schema.py` should be tested in a file named `test_schema.py` which should import the module using `from iceberg import schema`). That way when you're looking at an individual test, it's almost always a safe assumption that the objects that start with `schema.` are what's being tested. That doesn't necessarily apply here in `conftest.py` which is mostly a collection of global fixtures so I think either is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
