rdblue commented on code in PR #4703:
URL: https://github.com/apache/iceberg/pull/4703#discussion_r868755932
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -361,10 +361,12 @@ private CloseableIterable<ManifestEntry<DataFile>>
addedDataFiles(TableMetadata
* @param base table metadata to validate
* @param startingSnapshotId id of the snapshot current at the start of the
operation
* @param dataFiles data files to validate have no new row deletes
+ * @param ignorePosDeletes whether position deletes should be ignored in
validation
*/
protected void validateNoNewDeletesForDataFiles(TableMetadata base, Long
startingSnapshotId,
- Iterable<DataFile>
dataFiles) {
- validateNoNewDeletesForDataFiles(base, startingSnapshotId, null,
dataFiles, newFilesSequenceNumber != null);
+ Iterable<DataFile>
dataFiles, boolean ignorePosDeletes) {
+ validateNoNewDeletesForDataFiles(base, startingSnapshotId, null,
dataFiles, newFilesSequenceNumber != null,
+ ignorePosDeletes);
Review Comment:
It doesn't seem to make sense to make one flag explicit and the other one
implied by the sequence number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
