rdblue commented on code in PR #4703:
URL: https://github.com/apache/iceberg/pull/4703#discussion_r868756636
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -414,6 +423,10 @@ private void
validateNoNewDeletesForDataFiles(TableMetadata base, Long startingS
ValidationException.check(
Arrays.stream(deleteFiles).noneMatch(deleteFile ->
deleteFile.content() == FileContent.POSITION_DELETES),
"Cannot commit, found new position delete for replaced data file:
%s", dataFile);
+ } else if (ignorePosDeletes) {
Review Comment:
Nit: extra space.
This logic looks incorrect to me. If equality deletes are not ignored, then
this will always check for position deletes, regardless of the value for
`ignorePosDeletes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
