dhruv-pratap commented on code in PR #4706: URL: https://github.com/apache/iceberg/pull/4706#discussion_r869479467
########## python/setup.cfg: ########## @@ -43,6 +43,7 @@ package_dir = packages = find: python_requires = >=3.7 install_requires = + attrs Review Comment: There is Python built-in [dataclasses support](https://docs.python.org/3/library/dataclasses.html), which essentially was influenced by the [attrs community](https://www.attrs.org/en/stable/why.html) but it always seems to lack behind in terms of features. Unfortunately, pre-Python 3.10 dataclasses isn't as powerful as attrs. For instance, it doesn't support "kw_only" out of the box and requires us to write custom decorators to support that. I did talk briefly about this with Sam in [this conversation thread](https://github.com/apache/iceberg/pull/4706#discussion_r867216868). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
