danielcweeks commented on code in PR #4706: URL: https://github.com/apache/iceberg/pull/4706#discussion_r869637396
########## python/setup.cfg: ########## @@ -43,6 +43,7 @@ package_dir = packages = find: python_requires = >=3.7 install_requires = + attrs Review Comment: While the dataclasses support may lag, we've had a lot of pushback around library creep. I don't feel like the added value warrants bringing in a library in this case. This may feel overly conservative, but with Iceberg being as low-level as it will be in many frameworks moving forward, we really want to keep the dependencies as slim as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
