rizaon commented on PR #4518: URL: https://github.com/apache/iceberg/pull/4518#issuecomment-1123867490
Hi @danielcweeks @rdblue , can I get a follow up review on this PR please? I think we have not fully agree on how to decide which file to cache (regex vs specific callsite). I decided to go with regex approach in [dec17e2](https://github.com/apache/iceberg/pull/4518/commits/dec17e2c7d88b972c7d1c817c2cbe66322482146) because there are many callsites in Iceberg core that open metadata files. Please let me know how I can improve this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
