RussellSpitzer commented on code in PR #4674:
URL: https://github.com/apache/iceberg/pull/4674#discussion_r870480568
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java:
##########
@@ -221,7 +230,9 @@ private DeleteOrphanFiles.Result doExecute() {
List<String> orphanFiles = actualFileDF.join(validFileDF, joinCond,
"leftanti")
.as(Encoders.STRING())
.collectAsList();
-
+ if (useCaching) {
Review Comment:
this needs to be in a finally block, otherwise if we have an error in the
collect as list there is a possibility that we do not uncache. For services
running these actions that would be a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
