rdblue commented on code in PR #4242:
URL: https://github.com/apache/iceberg/pull/4242#discussion_r870739847
##########
core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java:
##########
@@ -154,16 +155,48 @@ public Schema.Field field(Schema.Field field,
Supplier<Schema> fieldResult) {
@Override
public Schema union(Schema union, Iterable<Schema> options) {
- Preconditions.checkState(AvroSchemaUtil.isOptionSchema(union),
- "Invalid schema: non-option unions are not supported: %s", union);
- Schema nonNullOriginal = AvroSchemaUtil.fromOption(union);
- Schema nonNullResult =
AvroSchemaUtil.fromOptions(Lists.newArrayList(options));
+ if (AvroSchemaUtil.isOptionSchema(union)) {
Review Comment:
Should this be using the `AvroSchemaWithType` visitor? I don't think that
was written when this was added, but I like the idea of aligning the types with
the right visitor, rather than having so much logic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
