bryanck commented on code in PR #4771:
URL: https://github.com/apache/iceberg/pull/4771#discussion_r873078455


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1435,12 +1463,66 @@ components:
           additionalProperties:
             type: string
 
+    TokenRequest:
+      description:
+        OAuth2 client credentials or token exchange request
+
+
+        See -
+
+        - Client credentials flow - 
https://datatracker.ietf.org/doc/html/rfc6749#section-4.4
+
+        - Token exchange flow - https://datatracker.ietf.org/doc/html/rfc8693
+      type: object
+      required:
+        - grant_type
+      properties:
+        grant_type:
+          type: string
+          enum:
+            - client_credentials
+            - urn:ietf:params:oauth:grant-type:token-exchange
+        client_id:
+          type: string
+        client_secret:
+          type: string
+        subject_token:

Review Comment:
   Just to note, the OAuth2 spec 
[recommends](https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1) 
passing client ID and secret in an `Authorization: Basic...` header, but 
passing in the request body is supported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to