rdblue commented on code in PR #4771:
URL: https://github.com/apache/iceberg/pull/4771#discussion_r873213045


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1435,12 +1463,66 @@ components:
           additionalProperties:
             type: string
 
+    TokenRequest:
+      description:
+        OAuth2 client credentials or token exchange request
+
+
+        See -
+
+        - Client credentials flow - 
https://datatracker.ietf.org/doc/html/rfc6749#section-4.4
+
+        - Token exchange flow - https://datatracker.ietf.org/doc/html/rfc8693
+      type: object
+      required:
+        - grant_type
+      properties:
+        grant_type:
+          type: string
+          enum:
+            - client_credentials
+            - urn:ietf:params:oauth:grant-type:token-exchange
+        client_id:
+          type: string
+        client_secret:
+          type: string
+        subject_token:

Review Comment:
   I'll add this to the description. I added them here because I saw that they 
can be passed here. They're also optional. Documenting this route isn't 
necessarily required, but the Swagger/OpenAPI docs say that you _can_ document 
the token endpoint and I thought it would be good to do as much as we can.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to