szlta commented on code in PR #4662:
URL: https://github.com/apache/iceberg/pull/4662#discussion_r875628617
##########
core/src/test/java/org/apache/iceberg/TestDataTableScan.java:
##########
@@ -130,4 +132,63 @@ public void testTableScanWithPlanExecutor() {
Assert.assertEquals(2, Iterables.size(scan.planFiles()));
Assert.assertTrue("Thread should be created in provided pool",
planThreadsIndex.get() > 0);
}
+
+ @Test
+ public void testReaddingPartitionField() throws Exception {
+ Assume.assumeTrue(formatVersion == 2);
Review Comment:
The change itself only affects V2. Since in V1 the reused partition field
names always get appended by the ID, the fix is a no-op there. Another reason
for this assume() call is that expected file structure differs greatly in V1
due to the void transformations that deleted partition fields get converted to,
the test code would be quite bloated :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
