szlta commented on code in PR #4662:
URL: https://github.com/apache/iceberg/pull/4662#discussion_r877900238


##########
core/src/test/java/org/apache/iceberg/TestDataTableScan.java:
##########
@@ -130,4 +132,63 @@ public void testTableScanWithPlanExecutor() {
     Assert.assertEquals(2, Iterables.size(scan.planFiles()));
     Assert.assertTrue("Thread should be created in provided pool", 
planThreadsIndex.get() > 0);
   }
+
+  @Test
+  public void testReaddingPartitionField() throws Exception {
+    Assume.assumeTrue(formatVersion == 2);

Review Comment:
   Right. Btw I spotted an unnecessary if statement in your example: 
https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestMetadataTableFilters.java#L385
   I guess all these could be cleaned up in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to