wmoustafa commented on code in PR #4732:
URL: https://github.com/apache/iceberg/pull/4732#discussion_r876055557


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -462,7 +483,7 @@ public NestedField asOptional() {
       if (isOptional) {
         return this;
       }
-      return new NestedField(true, id, name, type, doc);
+      return new NestedField(true, id, name, type, doc, initialDefault, 
writeDefault);

Review Comment:
   +1, but I think we could handle that in the table API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to