rdblue commented on PR #4732: URL: https://github.com/apache/iceberg/pull/4732#issuecomment-1130185141
@wmoustafa, @rzhang10, overall this looks fine to me. The only issue I have is that if we were to merge this now, we'd be updating a public API when there is no implementation behind it. I think we should hold off on merging this until it is time to expose the ability to set these. Before we do this, there are related PRs that we can get done: * Add the JSON value parser * Add as much as possible to Parquet, Avro, and ORC readers, like being able to read with a fake map of default values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
