RussellSpitzer commented on code in PR #4800:
URL: https://github.com/apache/iceberg/pull/4800#discussion_r877560914
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalog.java:
##########
@@ -43,4 +49,8 @@ public Table loadTable(Identifier ident) throws
NoSuchTableException {
return new SparkTable(table, false);
}
+
+ public static void setDummyIcebergTbl(Table dummyTbl) {
Review Comment:
Probably not needed, but you could do the similar map of "Identifier ->
Table" and just allow our tests to just insert new tables into that map and
then request them on demand. Then have a method clear it out after each test.
Just thinking about this for tests which run in multiple parameterizations
(which will have the same static dummyIcebergTbl)
I know i'm biased since this is how I did it my other example, I like your
placement in the Catalog here much more than mine though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
