RussellSpitzer commented on code in PR #4800:
URL: https://github.com/apache/iceberg/pull/4800#discussion_r878194963
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -224,7 +227,7 @@ private Expression
conflictDetectionFilter(SparkBatchQueryScan queryScan) {
@Override
public void abort(WriterCommitMessage[] messages) {
for (WriterCommitMessage message : messages) {
- if (message != null) {
+ if (message != null && cleanupOnAbort) {
Review Comment:
minor nit here, but we can test this outside the loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
