Fokko commented on code in PR #4742:
URL: https://github.com/apache/iceberg/pull/4742#discussion_r877579114
##########
python/src/iceberg/types.py:
##########
@@ -146,7 +146,7 @@ class NestedField(IcebergType):
name: str = field()
field_type: IcebergType = field()
is_optional: bool = field(default=True)
- doc: Optional[str] = field(default=None, repr=False)
+ doc: Optional[str] = field(default=None, repr=False, compare=False,
hash=False)
Review Comment:
@rdblue do we want to compare the docs as well? I know that for Avro we only
compare the fields that are part of the canonical representation. I caught this
in a test where my example didn't have the docs 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
