rdblue commented on code in PR #4742:
URL: https://github.com/apache/iceberg/pull/4742#discussion_r883232531
##########
python/src/iceberg/types.py:
##########
@@ -146,7 +146,7 @@ class NestedField(IcebergType):
name: str = field()
field_type: IcebergType = field()
is_optional: bool = field(default=True)
- doc: Optional[str] = field(default=None, repr=False)
+ doc: Optional[str] = field(default=None, repr=False, compare=False,
hash=False)
Review Comment:
We compare docs in the Java implementation. That's because equality for
types is that the type matches exactly, including documentation.
The question about whether a field is "equal" if the doc string is different
is the reason why we don't implement `equals` in Java's `Schema` class. We
could do the same here if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
