samredai commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r878796846
##########
python/src/iceberg/expressions/base.py:
##########
@@ -137,6 +74,30 @@ def __invert__(self) -> "BooleanExpression":
...
+class BoundPredicate(ABC):
+ def __init__(self, left, right):
+ """A concrete predicate must have a `left` and `right`"""
+ self._left = left
+ self._right = right
+
+ @abstractmethod
+ def eval(self, obj) -> bool:
+ """Evaluate the bound predicate"""
+ ...
Review Comment:
The new linter stuff recently added is complaining about this line. The
`...` isn't needed if you have a docstring. Same thing a few lines down in the
`bind` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
