kbendick commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r882950183
##########
python/src/iceberg/expressions/base.py:
##########
@@ -137,6 +74,28 @@ def __invert__(self) -> "BooleanExpression":
...
+class BoundPredicate(ABC):
+ def __init__(self, left, right):
+ """A concrete predicate must have a `left` and `right`"""
+ self._left = left
+ self._right = right
Review Comment:
The usage of `left` and `right` here is somewhat confusing for me. Is this
something that I missed that differs (or is renamed) from the Java library?
Or possibly `left` and `right` correspond tot the java `term` and `literal`
arguments of `BoundLiteralPredicate`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
