Fokko commented on code in PR #4811: URL: https://github.com/apache/iceberg/pull/4811#discussion_r879859796
########## python/.pre-commit-config.yaml: ########## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +files: ^python/ Review Comment: Hey @dhruv-pratap. Yes, we need this, otherwise, it will touch most of the repo (including all the Java files) because of trailing whitespaces and end-of-line checks. We could remove this, but then it should be a separate PR. It is skipping everything on your end because it will only check the files you've touched. Pre-commit does this based on git (it checks like `git status`). This is helpful when the project becomes bigger, and the checks take more time. Otherwise, we can also disable this by always running `pre-commit run --all-files`. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
