Fokko commented on code in PR #4811: URL: https://github.com/apache/iceberg/pull/4811#discussion_r879861699
########## python/src/iceberg/io/pyarrow.py: ########## @@ -26,10 +26,15 @@ from typing import Union from urllib.parse import urlparse +from iceberg.io.base import ( + FileIO, + InputFile, + InputStream, + OutputFile, + OutputStream, +) from pyarrow.fs import FileInfo, FileSystem, FileType -from iceberg.io.base import FileIO, InputFile, InputStream, OutputFile, OutputStream Review Comment: Yes, this was actually caused by a misconfiguration in paths. I've reverted it and the import groups are nicely separated again. I'm also happy to explicitly add a check on this: https://github.com/PyCQA/flake8-import-order but that might also be too much :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
