jackye1995 commented on code in PR #4695:
URL: https://github.com/apache/iceberg/pull/4695#discussion_r881209149
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -357,6 +357,13 @@ public class AwsProperties implements Serializable {
*/
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
+ /**
+ * Used by {@link LakeFormationAwsClientFactory}.
+ * The expiry lead time of the lakeformation credentials in seconds, default
to 60 seconds.
+ */
+ public static final String LAKE_FORMATION_EXPIRY_LEAD_SEC =
"lakeformation.expiry-lead-time";
+ public static final int LAKE_FORMATION_EXPIRY_LEAD_SEC_DEFAULT = 60;
Review Comment:
prefer millisecond as unit, long as data type, `-millis` suffix in config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
