jackye1995 commented on code in PR #4695:
URL: https://github.com/apache/iceberg/pull/4695#discussion_r881210507
##########
aws/src/main/java/org/apache/iceberg/aws/lakeformation/LakeFormationAwsClientFactory.java:
##########
@@ -132,27 +145,90 @@ private LakeFormationClient lakeFormation() {
.build();
}
+ static class LakeFormationTemporaryCredentials {
+
+ private final AwsCredentials credentials;
+ private final Instant sessionCredentialsExpiration;
+
+ LakeFormationTemporaryCredentials(AwsCredentials credentials, Instant
expiration) {
+ this.credentials = credentials;
+ this.sessionCredentialsExpiration = expiration;
+ }
+
+ AwsCredentials credentials() {
+ return credentials;
+ }
+
+ Instant sessionCredentialsExpiration() {
+ return sessionCredentialsExpiration;
+ }
+ }
+
static class LakeFormationCredentialsProvider implements
AwsCredentialsProvider {
private LakeFormationClient client;
private String tableArn;
+ private final long expiryLeadTimeForRefreshInSecs;
+
+ private LakeFormationTemporaryCredentials cachedCredentials;
+ private final Cache<String, LakeFormationTemporaryCredentials> cache;
- LakeFormationCredentialsProvider(LakeFormationClient lakeFormationClient,
String tableArn) {
+ LakeFormationCredentialsProvider(LakeFormationClient lakeFormationClient,
+ String tableArn, long expiryLeadTimeForRefreshInSecs) {
this.client = lakeFormationClient;
this.tableArn = tableArn;
+ this.expiryLeadTimeForRefreshInSecs = expiryLeadTimeForRefreshInSecs;
+ this.cache = Caffeine.newBuilder()
+ .expireAfter(new Expiry<String, LakeFormationTemporaryCredentials>()
{
+ @Override
+ public long expireAfterCreate(@NonNull String key,
Review Comment:
nit: if we cannot fit all arguments on the same line, let's put one argument
per line, like:
```
public long expireAfterCreate(
@NonNull String key,
@NonNull LakeFormationTemporaryCredentials value,
long currentTime) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
