rdblue commented on code in PR #4831:
URL: https://github.com/apache/iceberg/pull/4831#discussion_r883148811
##########
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -112,7 +109,17 @@ public static Object[][] parameters() {
),
"avro",
false,
- WRITE_DISTRIBUTION_MODE_RANGE
+ WRITE_DISTRIBUTION_MODE_RANGE,
+ false
+ },
+ { "testhadoop", SparkCatalog.class.getName(),
+ ImmutableMap.of(
+ "type", "hadoop"
+ ),
+ "parquet",
+ RANDOM.nextBoolean(),
+ WRITE_DISTRIBUTION_MODE_HASH,
+ true
Review Comment:
Why not add bloom filter testing to one of the existing cases? I don't see a
reason why this can't be tested along with other cases. And Spark tests already
take a long time. We should avoid adding more cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
