rdblue commented on code in PR #4831:
URL: https://github.com/apache/iceberg/pull/4831#discussion_r883151676
##########
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##########
@@ -106,7 +108,8 @@
startRowPositions[i] = offsetToStartPos == null ? 0 :
offsetToStartPos.get(rowGroup.getStartingPos());
boolean shouldRead = filter == null || (
statsFilter.shouldRead(typeWithIds, rowGroup) &&
- dictFilter.shouldRead(typeWithIds, rowGroup,
reader.getDictionaryReader(rowGroup)));
+ dictFilter.shouldRead(typeWithIds, rowGroup,
reader.getDictionaryReader(rowGroup)) &&
+ bloomFilter.shouldRead(typeWithIds, rowGroup,
reader.getBloomFilterDataReader(rowGroup)));
Review Comment:
Nit: this indentation looks suspicious to me. The last line was also after
`&&` but this one has a different indentation level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
