findepi commented on code in PR #4863:
URL: https://github.com/apache/iceberg/pull/4863#discussion_r883419844
##########
core/src/main/java/org/apache/iceberg/util/Tasks.java:
##########
@@ -88,8 +89,17 @@ public UnrecoverableException(Throwable cause) {
private long maxSleepTimeMs = 600000; // 10 minutes
private long maxDurationMs = 600000; // 10 minutes
private double scaleFactor = 2.0; // exponential
+ private boolean hasStarted = false;
+ /**
+ * @deprecated Use {@link #Builder(Iterator)} instead.
Review Comment:
> I think you can use `@deprecated since 0.14.0`.
I don't think it adds value. If a user is < 0.14, they won't see deprecation
notice.
If they are on >= 0.14, they see it.
It would be valuable if it comes with the "will be removed", but it's not my
call to make promises like this.
Please advise what should i do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
