kbendick commented on code in PR #4863:
URL: https://github.com/apache/iceberg/pull/4863#discussion_r884323642
##########
core/src/main/java/org/apache/iceberg/util/Tasks.java:
##########
@@ -88,8 +89,17 @@ public UnrecoverableException(Throwable cause) {
private long maxSleepTimeMs = 600000; // 10 minutes
private long maxDurationMs = 600000; // 10 minutes
private double scaleFactor = 2.0; // exponential
+ private boolean hasStarted = false;
+ /**
+ * @deprecated Use {@link #Builder(Iterator)} instead.
Review Comment:
It doesn’t have to be added if it truly doesn’t add values.
We have some places where it’s not present, but I also tend to think of it
as a notice for people who fork the project in case they’re using it.
I also think of it as something that reminds us (or specifically release
managers) when something can be removed entirely.
But I agree here it wouldn’t present much end user facing value. Mostly this
comment was just to point out something that is standard practice but not
enough so to be automated / forced (due to situations like this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
