stevenzwu commented on code in PR #4744: URL: https://github.com/apache/iceberg/pull/4744#discussion_r883956271
########## core/src/main/java/org/apache/iceberg/BaseIncrementalAppendScan.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.util.List; +import java.util.Set; +import org.apache.iceberg.events.IncrementalScanEvent; +import org.apache.iceberg.events.Listeners; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.FluentIterable; +import org.apache.iceberg.relocated.com.google.common.collect.Iterables; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.util.SnapshotUtil; +import org.apache.iceberg.util.TableScanUtil; + +class BaseIncrementalAppendScan extends BaseScan<IncrementalAppendScan> implements IncrementalAppendScan { + + BaseIncrementalAppendScan(TableOperations ops, Table table) { + this(ops, table, table.schema(), new TableScanContext()); + } + + BaseIncrementalAppendScan(TableOperations ops, Table table, Schema schema, TableScanContext context) { + super(ops, table, schema, context); + } + + @Override + protected IncrementalAppendScan newRefinedScan( + TableOperations newOps, Table newTable, Schema newSchema, TableScanContext newContext) { + return new BaseIncrementalAppendScan(newOps, newTable, newSchema, newContext); + } + + @Override + public IncrementalAppendScan fromSnapshotInclusive(long fromSnapshotId) { Review Comment: Good question. I think it is outside the scope of the scan/source. Let's use the more common streaming source (kafka with Avro record). The problem of schema evolution is outside the scope of Kafka source. If the schema is evolved in a backward compatible, the consumers won't break. If the schema evolution is incompatible, then consumers should be notified and the breaking change need to be coordinated. If there is a Avro schema registry, notification service can be provided by schema registry or some other control plane. Now coming to Iceberg streaming source, I would assume similar expectation. maybe some control plane service can notify consumers of table schema change. Then consumers can take proper action if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
