stevenzwu commented on code in PR #4744:
URL: https://github.com/apache/iceberg/pull/4744#discussion_r883958058
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -168,7 +172,17 @@ Long fromSnapshotId() {
TableScanContext fromSnapshotId(long id) {
return new TableScanContext(snapshotId, rowFilter, ignoreResiduals,
caseSensitive, colStats, projectedSchema, selectedColumns, options,
id, toSnapshotId,
- planExecutor);
+ planExecutor, fromSnapshotInclusive);
+ }
+
+ TableScanContext fromSnapshotIdInclusive(long id) {
Review Comment:
agree. since this is a non-public class, it is safe to rename the old setter
of `fromSnapshotId` to `fromSnapshotIdExclusive`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
